Allows configurable iteration order in AggregateDataSource, and adds a configurable version #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y provenance marshalling is tested.
eelstretching
approved these changes
Apr 14, 2021
|
Ok, I'll add that in the pass when we upgrade OLCUT as I'll be back in here removing the todos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an enum to
AggregateDataSourcethat lets users pick the iteration order. The two options are sequential, which was the old behaviour, where each internal data source is exhausted in sequence, or round robin which draws an example from each data source in turn.Adds
AggregateConfigurableDataSourcewhich is the same asAggregateDataSourcebut can be configured.There's also a slight refactor in the test helpers to expose provenance marshalling checks.
Motivation
Building data sources from multiple files is a pain, and
AggregateDataSourcehad slightly misleading documentation. This fixes the docs and makes it easier to aggregate things as they can be all placed in one config file.Partial fix for #123 until we have a bigger refactor of file based data sources.